[SPARK-41660][SQL][3.3] Only propagate metadata columns if they are used #40889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
viirya
reviewed
Apr 21, 2023
| node | ||
| } else { | ||
| val newNode = addMetadataCol(node) | ||
| val newNode = node.mapChildren(addMetadataCol(_, metaCols.map(_.exprId).toSet)) |
Member
There was a problem hiding this comment.
Why this only does addMetadataCol on children?
Contributor
There was a problem hiding this comment.
This looks correct to me because we need to propagate metadata cols to this node and need to add metadata cols in its children. Does master branch have the same code here?
Contributor
Author
There was a problem hiding this comment.
Yes, master branch has the same code.
cloud-fan
approved these changes
Apr 21, 2023
viirya
approved these changes
Apr 21, 2023
RussellSpitzer
approved these changes
Apr 21, 2023
Member
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
Thanks! If anyone else was seeing odd issues with mispropagated metadata columns this should fix for them as well.
huaxingao
added a commit
that referenced
this pull request
Apr 21, 2023
### What changes were proposed in this pull request? backporting #39152 to 3.3 ### Why are the changes needed? bug fixing ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? UT Closes #40889 from huaxingao/metadata. Authored-by: huaxingao <[email protected]> Signed-off-by: huaxingao <[email protected]>
Contributor
Author
|
Merged to branch-3.3. Thank you all for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
backporting #39152 to 3.3
Why are the changes needed?
bug fixing
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT